Revert "Add riff raff project tag" #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akash1810 Question: we should be able to test if tags do not get removed by deploying this branch to CODE deploying cdk playground, right? |
Yes. Indeed we patched this behaviour in #1379. |
|
@akash1810 tested with the latest changes from #1379 and yeah, it no longer removes the tags and behaves how we originally expected. I've enabled auto-merge if you're up for giving it a thumbs up |
akash1810
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1374
It's emerged that this change might break deployments for projects that use the ami update functionality. If the stack has enough components that all need to be tagged, the list of events in the cloudformation stack becomes so long that it breaks.
See
https://github.com/guardian/riff-raff/blob/main/magenta-lib/src/main/scala/magenta/deployment_type/AmiCloudFormationParameter.scala#L34
We think that removing this tag should be safe as riff raff should not remove the tags that have already been added. It will just stop adding tags to new deployments, and the ~40 projects that rely on this ami update deployment type should continue to work without issue.