chore(deps): Use logging solution from devx-logs #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The devx-logs solution is more "official"...
AshCorr
approved these changes
Oct 16, 2023
| @@ -29,7 +29,7 @@ const cloudqueryImage = ContainerImage.fromRegistry( | |||
| ); | |||
|
|
|||
| const firelensImage = ContainerImage.fromRegistry( | |||
| 'ghcr.io/guardian/hackday-firelens:main', | |||
| 'ghcr.io/guardian/devx-logs:main', | |||
There was a problem hiding this comment.
Not for this PR, but perhaps in future we could consider using a specific version of devx-logs instead of always using main? We'd have issues if we ever needed to release a breaking version of devx-logs!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
guardian/devx-logs#32 should be merged first, to ensure log lines have the correct markers in Central ELK.
What does this change?
Replaces the logging container with the one from devx-logs.
Why?
The devx-logs solution is more "official", and with this change we can archive https://github.com/guardian/hackday-firelens.
How has it been verified?
#369 tests guardian/devx-logs#32. Once deployed to CODE, the logs in Central ELK look like this:
Before
After