Scala 2.13 fixes

Switched from `JavaConverters` to 2.13's `CollectionConverters`.

Widening conversion from `Long` to `Double` is deprecated, so used `toDouble` instead.

Previously `Buffer` could be assigned to `Seq`, because `Seq` was mutable. Now `Seq` is immutable by default, so `toSeq` is needed to create a `Seq` from a `Buffer`.

`Either` is now right-biased, so `.right` is no longer needed.

`.mapValues` is deprecated, need `.view.mapValues` instead. `.toMap` is also needed to get back to a `Map` from a `MapView`.

Auto-application is deprecated, so `()` must be added in some cases.

Deleted `Enumerators` because it wasn't used, and it was using features unsupported in Scala 2.13.

app/conf/Configuration.scala

@@ -16,7 +16,7 @@ import play.api.{Configuration => PlayConfiguration}
 import story_packages.services.Logging
 
 import scala.language.reflectiveCalls
-import scala.collection.JavaConverters._
+import scala.jdk.CollectionConverters._
 
 class BadConfigurationException(msg: String) extends RuntimeException(msg)
 

app/story_packages/metrics/CloudWatch.scala

@@ -7,7 +7,7 @@ import com.amazonaws.services.cloudwatch.model._
 import conf.ApplicationConfiguration
 import story_packages.services.Logging
 
-import scala.collection.JavaConverters._
+import scala.jdk.CollectionConverters._
 
 class CloudWatch(config: ApplicationConfiguration) extends Logging {
 

app/story_packages/metrics/FrontendMetrics.scala

@@ -26,7 +26,7 @@ case class FrontendStatisticSet(metric: FrontendMetric, datapoints: List[DataPoi
   lazy val sampleCount: Double = datapoints.size
   lazy val maximum: Double = Try(datapoints.maxBy(_.value).value).getOrElse(0L).toDouble
   lazy val minimum: Double = Try(datapoints.minBy(_.value).value).getOrElse(0L).toDouble
-  lazy val sum: Double = datapoints.map(_.value).sum
+  lazy val sum: Double = datapoints.map(_.value).sum.toDouble
   lazy val average: Double =
     Try(sum / sampleCount).toOption.getOrElse(0L)
 

app/story_packages/metrics/metrics.scala

@@ -11,6 +11,7 @@ import story_packages.services.Logging
 import scala.concurrent.ExecutionContext.Implicits.global
 import scala.concurrent.duration._
 import scala.jdk.CollectionConverters._
+import scala.collection.mutable.Buffer
 
 object SystemMetrics {
 
@@ -22,17 +23,17 @@ object SystemMetrics {
 
     def gcCount: Double = {
       val totalGcCount = bean.getCollectionCount
-      totalGcCount - lastGcCount.getAndSet(totalGcCount)
+      (totalGcCount - lastGcCount.getAndSet(totalGcCount)).toDouble
     }
 
     def gcTime: Double = {
       val totalGcTime = bean.getCollectionTime
-      totalGcTime - lastGcTime.getAndSet(totalGcTime)
+      (totalGcTime - lastGcTime.getAndSet(totalGcTime)).toDouble
     }
   }
 
 
-  lazy val garbageCollectors: Seq[GcRateMetric] = ManagementFactory.getGarbageCollectorMXBeans.asScala.map(new GcRateMetric(_))
+  lazy val garbageCollectors: Seq[GcRateMetric] = ManagementFactory.getGarbageCollectorMXBeans.asScala.map(new GcRateMetric(_)).toSeq
 
 
   // divide by 1048576 to convert bytes to MB

app/story_packages/services/Database.scala

@@ -14,7 +14,7 @@ import conf.ApplicationConfiguration
 import story_packages.updates.ReindexPage
 import story_packages.util.Identity._
 
-import scala.collection.JavaConverters._
+import scala.jdk.CollectionConverters._
 import scala.concurrent.Future
 import scala.util.{Failure, Success, Try}
 

app/story_packages/services/DynamoReindexJobs.scala

@@ -9,7 +9,7 @@ import story_packages.metrics.ReindexMetrics
 import conf.ApplicationConfiguration
 import story_packages.updates._
 
-import scala.collection.JavaConverters._
+import scala.jdk.CollectionConverters._
 
 class DynamoReindexJobs(config: ApplicationConfiguration) extends Logging {
   private lazy val client =

app/story_packages/updates/AuditingUpdates.scala

@@ -5,7 +5,7 @@ import play.api.libs.json.Json
 import conf.ApplicationConfiguration
 import story_packages.services.Logging
 
-import scala.collection.JavaConverters._
+import scala.jdk.CollectionConverters._
 
 class AuditingUpdates(config: ApplicationConfiguration) extends Logging {
 

app/story_packages/util/ContentUpgrade.scala

@@ -46,8 +46,8 @@ object ContentUpgrade {
   def upgradeItem(json: JValue): JValue = {
     Try({
       val jsonString = JsonMethods.compact(JsonMethods.render(json))
-      val maybeParsedJson: Option[Json] = parser.parse(jsonString).right.toOption
-      val maybeCapiContent: Option[Content] = maybeParsedJson.flatMap(json => json.as[Content].right.toOption)
+      val maybeParsedJson: Option[Json] = parser.parse(jsonString).toOption
+      val maybeCapiContent: Option[Content] = maybeParsedJson.flatMap(json => json.as[Content].toOption)
 
       (json, maybeCapiContent) match {
         case (jsObject: JObject, Some(content)) =>

app/story_packages/util/SanitizeInput.scala

@@ -10,7 +10,7 @@ object SanitizeInput {
   def fromString(s: String) = sanitizeRegex.replaceAllIn(s, "")
 
   def fromConfigSeo(config: ConfigJson): ConfigJson = {
-    config.copy(fronts = config.fronts.mapValues(sanitizeSeoInputFromFront))
+    config.copy(fronts = config.fronts.view.mapValues(sanitizeSeoInputFromFront).toMap)
   }
 
   private def sanitizeSeoInputFromFront(front: FrontJson): FrontJson = front.copy(

conf/routes

@@ -23,7 +23,7 @@ GET         /editorial                               controllers.ViewsController
 GET         /training                                controllers.ViewsController.collectionEditor()
 
 GET         /collection/*collectionId                controllers.FaciaToolController.getCollection(collectionId)
-POST        /edits                                   controllers.FaciaToolController.collectionEdits
+POST        /edits                                   controllers.FaciaToolController.collectionEdits()
 GET         /defaults                                controllers.DefaultsController.configuration()
 
 GET         /story-package/*id                       controllers.StoryPackagesController.getPackage(id)

test/package.scala

@@ -4,6 +4,5 @@ import org.scalatest.Suites
 
 class FaciaToolTestSuite extends Suites (
   new story_packages.metrics.DurationMetricTest,
-  new story_packages.util.EnumeratorsTest,
   new story_packages.util.RichFutureTest,
   new story_packages.util.SanitizeInputTest) {}