-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt GitHub Actions for CI #189
Conversation
Also switches from deprecated sbt-riffraff-artifact plugin to devx recommendation guardian/actions-riff-raff. Based on guardian/mobile-n10n#1151 and guardian/s3-upload#53
I've done a cursory test in CODE, adding and removing an article from a story package |
java-version: '8' | ||
distribution: 'corretto' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding cache: 'sbt'
here is apparently helpful for performance, I learnt here.
.github/workflows/ci.yml
Outdated
id-token: write | ||
contents: read | ||
steps: | ||
- uses: actions/checkout@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a v4 of this action.
.github/workflows/ci.yml
Outdated
steps: | ||
- uses: actions/checkout@v3 | ||
|
||
- uses: aws-actions/configure-aws-credentials@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also a v4 of this.
.github/workflows/ci.yml
Outdated
grunt --stack bundle | ||
|
||
- name: SBT | ||
run: sbt "clean;compile;test;assets;Debian / packageBin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note on batch mode, apparently it makes builds run more slowly. Having said that, this discussion suggests that these sbt commands will run in batch mode, and sequentially (i.e. no need for semicolons either), anyway.
I believe you can also remove the space and have Debian/packageBin
, to remove the need for quotes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks @samanthagottlieb, I'll merge+deploy tomorrow |
Seen on PROD (merged by @davidfurey 7 minutes and 36 seconds ago) Please check your changes! |
What does this change?
This change adopt GitHub Actions for CI, replacing TeamCity which DevX are switching off in Q2 2023.
This change isn't exactly a no-op switch, as the
sbt-riffraff-artifact
plugin has been removed in favour ofguardian/actions-riff-raff
.How to test
Notes
.deb
filesize is different between build 187 and build 191, but unzipping yields no differences so I presume this is a quirk of the zip compression