Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-Scala 2.13 Scalafix #197

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Pre-Scala 2.13 Scalafix #197

merged 1 commit into from
Jul 23, 2024

Conversation

JamieB-gu
Copy link
Contributor

Added and ran scalafix with two rules. Preparation for upgrading to Scala 2.13. This has added a number of type annotations.

sbt
> scalafixEnable
> scalafixAll

Paired with @rtyley

Preparation for upgrading to Scala 2.13.

This has added a number of type annotations.
@JamieB-gu JamieB-gu requested a review from rtyley July 23, 2024 16:27
Copy link
Member

@rtyley rtyley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - good to merge, as these are very low-risk changes: adding type-annotations and avoiding procedure syntax.

@JamieB-gu JamieB-gu merged commit 5986497 into main Jul 23, 2024
3 checks passed
@prout-bot
Copy link

Seen on PROD (merged by @JamieB-gu 6 minutes and 24 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants