Improve readability #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with vim I manually did some operations taking care of sense
:%s/)/ )/gc
:%s/(/( /gc
:%s/){/) {/gc
:%s/]/ ]/gc
:%s/[/[ /gc
:%s/,/, )/gc
:%s/./ . )/gc
:%s/=/ = )/gc
:%s/+/ + )/gc
:%s/-/ - /gc
rogerpueyo
suggested changes
Oct 27, 2017
There was a problem hiding this comment.
Thanks for your pull request, @pedro-nonfree . While it's true that the current code has many style issues, I'd suggest you to adhere to one of the well-known coding standards such as PEAR (https://pear.php.net/manual/en/standards.php) or PSR-2 (http://www.php-fig.org/psr/psr-2/) and apply it to all the code.
Additionally, the commit can not be automatically merged anymore.
|
I did this https://github.com/guifi-exo/wiki/blob/master/howto/php-cs-fixer_usage.md I think is not that easy to apply. After indenting, something goes wrong (because we should review code). Probably we should apply something like this in all guifi projects. We will see, if you don't care, let's remain this open |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with vim I manually did some operations taking care of sense
:%s/)/ )/gc
:%s/(/( /gc
:%s/){/) {/gc
:%s/]/ ]/gc
:%s/[/[ /gc
:%s/,/, )/gc
:%s/./ . )/gc
:%s/=/ = )/gc
:%s/+/ + )/gc
:%s/-/ - /gc