update tests (#1)

gurgunday · Jan 20, 2024 · b9b2122 · b9b2122
1 parent 1fb3d47
commit b9b2122
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 22 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -15,7 +15,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [^18, ^20]
+        node-version: [^18, lts/*]
 
     steps:
       - uses: actions/checkout@v4

diff --git a/test/index.js b/test/index.js
@@ -2,24 +2,24 @@ import test from "node:test";
 import assert from "node:assert";
 import { html } from "../src/index.js";
 
-const username = "G";
+const username = "Paul";
 const descriptionSafe = "This is a safe description.";
 const descriptionUnsafe =
   "<script>alert('This is an unsafe description.')</script>";
 const array1 = [1, 2, 3, 4, 5];
 const conditionTrue = true;
 const conditionFalse = false;
-const empty = "";
+const emptyString = "";
 
-test("renders correctly", () => {
-  assert.strictEqual(html({ raw: [] }, []), "");
+test("renders empty input", () => {
+  assert.strictEqual(html({ raw: [] }), "");
 });
 
-test("renders correctly", () => {
-  assert.strictEqual(html`${empty}`, "");
+test("renders empty input", () => {
+  assert.strictEqual(html`${emptyString}`, "");
 });
 
-test("renders correctly", () => {
+test("renders normal input", () => {
   assert.strictEqual(html`Hey, ${username}!`, `Hey, ${username}!`);
 });
 
@@ -37,13 +37,6 @@ test("escapes unsafe output", () => {
   );
 });
 
-test("escapes unsafe output", () => {
-  assert.strictEqual(
-    html`<p>${descriptionUnsafe}</p>`,
-    `<p>&lt;script&gt;alert(&apos;This is an unsafe description.&apos;)&lt;/script&gt;</p>`,
-  );
-});
-
 test("renders arrays", () => {
   assert.strictEqual(
     html`<p>${[descriptionSafe, descriptionUnsafe]}</p>`,
@@ -59,8 +52,8 @@ test("bypass escaping", () => {
 });
 
 test("renders wrapped html calls", () => {
+  // prettier-ignore
   assert.strictEqual(
-    // prettier-ignore
     html`<p>!${conditionTrue ? html`<strong>${descriptionUnsafe}</strong>` : ""}</p>`,
     "<p><strong>&lt;script&gt;alert(&apos;This is an unsafe description.&apos;)&lt;/script&gt;</strong></p>",
   );
@@ -75,7 +68,6 @@ test("renders multiple html calls", () => {
         !${conditionFalse ? html`<em> ${array1} </em>` : ""}
       </p>
     `,
-    // it should be formatted
     `
       <p>
         <strong> This is a safe description. </strong>
@@ -89,26 +81,26 @@ test("renders multiple html calls", () => {
 test("renders multiple html calls with different expression types", () => {
   const obj = {};
   obj.toString = () => {
-    return "Description of the object.";
+    return "description of the object";
   };
 
+  // prettier-ignore
   assert.strictEqual(
     html`
       <p>
         !${conditionTrue ? html`<strong> ${descriptionSafe} </strong>` : ""}
         !${conditionFalse
           ? ""
-          : // prettier-ignore
+          :
             html`<em> ${array1.map((i) => {return i + 1;})} </em>`}<br />
-        And also, ${false} ${null}${undefined}${obj}
+        And also, ${false} ${null}${undefined}${obj} is ${true}
       </p>
     `,
-    // it should be formatted
     `
       <p>
         <strong> This is a safe description. </strong>
         <em> 23456 </em><br />
-        And also, false Description of the object.
+        And also, false description of the object is true
       </p>
     `,
   );