-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Baysor>=7.0.0 #127
Conversation
Latest version of Baysor outputs either `segmentation_polygons2D.json` or `segmentation_polygons3D.json` depending on input data. This very basic fix would reestablish compatibility, in case users aren't running both 2D and 3D and outputting results in same folder
Some Baysor options were removed and the output format of the polygons needs to be changed to fit with the next steps of the pipeline.
Also, for now, you'll see that it doesn't support 3D segmentation. It will require additional updates to support it |
Thanks a lot for looking into that ! And thank you for including the
|
Could you open an issue with a detailed error log? |
I'm reinstalling my environment right now, I'll create an issue if I encounter it again. But anyway, you removed the |
Yes, I was making these changes in the So you can try the
|
Merging this PR, thanks @lguerard! |
Hi @lguerard, I added a test to check if the cell IDs are string
In the new 0.7.0 version, the cell IDs are strings, and we need to use the obs_names instead of CellID to compare to the loom matrix
Let me know if this works for you!