-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comseg cli #76
Comseg cli #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looking good! I added a few comments
Here is a todo list for the next steps:
|
Thanks for the changes! Regarding the CI, you can install pre-commit install
pre-commit run --all-files |
Ok thanks I just saw it |
I added comseg to the snakemake pipeline + few config file examples. Now I will complete ComSeg tutorial for API + CLI + snakemake all in the file : "other_segmentations.ipynb" |
Thanks for your updates, it looks very good! I fixed and cleaned a few things Also, I had some issues running comseg, now I get an error
After this, I will merge the PR! |
Ok thanks for reviewing!
I will do additional tests on other data this week, before the next push. |
Hello, Sorry it took so long, I think that it is now ready for your review. I added I modified the valid index patches of ComSeg so it run only on crops with nuclei. I updated the ComSeg dependency in the new pip version. However, I did not encounter the `PCA object has no attribute 'explained_variance_' issue, so I do not know why it occurred for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me, thanks @tdefa!
implementation of ComSeg cli
A function transcript_segmentation() was created to handle both Baysor and ComSeg