HexTiling: Define symbol to fix Mesa Intel compile issue; fix PI constant #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Dan. Didn't you hear that pi had been updated? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a Linux system that's picking up the embedded Intel HD Graphics 630, which is using the Mesa 22.3.0 driver. osgEarth is crashing (see #2343) for me. The other PR deals with the CXX cause of the crash. This change fixes the runtime issue.
The GLSL compiler is not happy with the file having no symbols defined and gives
0:279(1): error: syntax error, unexpected end of file. This fixes that problem by defining some symbols -- any symbol would be fine includingvoid doNothing() {}-- outside of theVP_STAGE_FRAGMENTifdef.After this change, Intel Mesa runs fine with no issues.
I also noticed that
M_PIwas off on a digit so I updated that.