Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: weejobs macos build issues #2448

Closed
wants to merge 1 commit into from
Closed

Conversation

remoe
Copy link
Contributor

@remoe remoe commented Feb 21, 2024

  • std::mutex doesn't have a string as a constructor.
  • initialize of a reference doesn't compile on clang

- std::mutex doesn't have a string as a constructor.
- initialize of a reference doesn't compile on clang
@gwaldron
Copy link
Owner

Hi Remo. Both of these occurred in clang because clang is evaluating templates before they are used.

Anyway, the first is a bug and I have fixed it in a separate push. Thanks.

The second however is not a problem with a default reference value, that is legal C++. The problem is that the struct context type is being forward-declared (since it's evaluating the template before it's used) and you cannot assign a default value to an argument of a forward-declared type. So I will try to rearrange the code to prevent this.

@remoe
Copy link
Contributor Author

remoe commented Feb 22, 2024

This is now solved by:

43237fd
e00f167

@remoe remoe closed this Feb 22, 2024
@remoe remoe deleted the fix/macos-build branch February 22, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants