Capabilities: Remove unused Version include that does not compile #2614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Dan. Yes. Local environment hid this problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in a recent refactor. Not sure how Windows is working here, as the "Version" file is in the build directory at
build_dir/build_include/osgEarth/VersionAnother fix is to update this back to
"osgEarth/Version". I suspect that removing this works simply because one of the other headers already includes it, but removing the header was a clean fix that compiled cleanly for me too.Without a change here, Linux builds are continuing to fail. Again, unsure how Windows is apparently working.