Skip to content

Commit

Permalink
Same type output from get_code_version_numbers
Browse files Browse the repository at this point in the history
  • Loading branch information
GarethCabournDavies committed Jul 14, 2023
1 parent 4d688f5 commit 6a70540
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion bin/plotting/pycbc_page_versioning
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ code_version_dict = get_code_version_numbers(

html_text += f'<h2>Version Information from Executables</h2>:<br>\n'
for key, value in code_version_dict.items():
value = value.decode()
html_text += '<li><b>%s</b>:<br><pre>%s</pre></li><hr><br><br>\n' \
% (key, str(value).replace('@', '&#64;'))

Expand Down
2 changes: 1 addition & 1 deletion pycbc/results/versioning.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def get_code_version_numbers(executable_names, executable_files):
version_string = subprocess.check_output(
[value.path, '--version'],
stderr=subprocess.STDOUT
)
).decode()
except subprocess.CalledProcessError:
version_string = "Executable fails on {} --version"
version_string = version_string.format(value.path)
Expand Down
2 changes: 1 addition & 1 deletion pycbc/workflow/versioning.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
in workflows
"""
import os
from pycbc.workflow.core import File, FileList, Executable
from pycbc.workflow.core import Executable


class VersioningExecutable(Executable):
Expand Down

0 comments on commit 6a70540

Please sign in to comment.