fix string issue

gwastro · Sep 4, 2024 · fc135de · fc135de
1 parent 82ee2b6
commit fc135de
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/bin/all_sky_search/pycbc_coinc_statmap b/bin/all_sky_search/pycbc_coinc_statmap
@@ -508,9 +508,9 @@ f.attrs['hierarchical_removal_iterations'] = h_iterations
 
 # Write whether hierarchical removals were removed against the
 # inclusive background or the exclusive background. Have to use
-# numpy.string_ datatype.
+# numpy.bytes_ datatype.
 if h_iterations != 0:
     hrm_method = args.hierarchical_removal_against
-    f.attrs['hierarchical_removal_method'] = numpy.string_(hrm_method)
+    f.attrs['hierarchical_removal_method'] = numpy.bytes_(hrm_method)
 
 logging.info("Done")
diff --git a/bin/all_sky_search/pycbc_sngls_statmap b/bin/all_sky_search/pycbc_sngls_statmap
@@ -436,10 +436,10 @@ f.attrs['hierarchical_removal_iterations'] = h_iterations
 
 # Write whether hierarchical removals were removed against the
 # inclusive background or the exclusive background. Have to use
-# numpy.string_ datatype.
+# numpy.bytes_ datatype.
 if h_iterations != 0:
     hrm_method = args.hierarchical_removal_against
-    f.attrs['hierarchical_removal_method'] = numpy.string_(hrm_method)
+    f.attrs['hierarchical_removal_method'] = numpy.bytes_(hrm_method)
 
 logging.info("Done")
 
diff --git a/pycbc/io/record.py b/pycbc/io/record.py
@@ -1507,7 +1507,7 @@ def _isstring(dtype):
     """Given a numpy dtype, determines whether it is a string. Returns True
     if the dtype is string or unicode.
     """
-    return dtype.type == numpy.unicode_ or dtype.type == numpy.string_
+    return dtype.type == numpy.unicode_ or dtype.type == numpy.bytes_
 
 
 def aliases_from_fields(fields):