update parameters.py #4397
Merged
update parameters.py #4397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahnitz
reviewed
Jul 5, 2023
pycbc/waveform/parameters.py
Outdated
| dtype=float, default=0., label=r"$\alpha$", | ||
| description="Right ascension (rad).") | ||
| dtype=float, default=0., label=r"$\alpha$", | ||
| description="Right ascension (rad) in geocentric coords.") |
There was a problem hiding this comment.
It doesn't make sense to say that ra/dec are in geocentric coordinates. They are uniquely defined, so there is no extra coordinate freedom.
ahnitz
reviewed
Jul 5, 2023
pycbc/waveform/parameters.py
Outdated
| description="Coalescence time (s).") | ||
| dtype=float, default=None, label=r"$t_c$ (s)", | ||
| description="Coalescence time (s) in " | ||
| "geocentric/SSB/LISA coords.") |
There was a problem hiding this comment.
@WuShichao Looking at this, I'd take out reference here to coordinates systems generally. I think it's going to end up being confusing.
ahnitz
requested changes
Jul 5, 2023
|
@ahnitz Poke :) |
ahnitz
reviewed
Jul 11, 2023
pycbc/waveform/parameters.py
Outdated
| delta_tc = Parameter("delta_tc", dtype=float, | ||
| label=r"$\Delta t_c~(\rm{s})$", | ||
| description="Coalesence time offset.") | ||
| description="Coalesence time offset in " + | ||
| "a certain coordinate system.") |
There was a problem hiding this comment.
Drop 'in a certain coordinate system'. I don't think that adds any clarification.
There was a problem hiding this comment.
@ahnitz Yeah, that makes sense. I have removed it.
|
@ahnitz Also, do not forget this PR, so we need to merge the plugin PR and this one, then frame transform module PR. |
ahnitz
approved these changes
Oct 19, 2023
PRAVEEN-mnl
pushed a commit
to PRAVEEN-mnl/pycbc
that referenced
this pull request
Nov 3, 2023
* update parameters.py * fix cc issue * Update parameters.py * Update parameters.py * fix cc issues * Update parameters.py
maxtrevor
pushed a commit
to maxtrevor/pycbc
that referenced
this pull request
Dec 11, 2023
* update parameters.py * fix cc issue * Update parameters.py * Update parameters.py * fix cc issues * Update parameters.py
bhooshan-gadre
pushed a commit
to bhooshan-gadre/pycbc
that referenced
this pull request
Mar 4, 2024
* update parameters.py * fix cc issue * Update parameters.py * Update parameters.py * fix cc issues * Update parameters.py
lpathak97
pushed a commit
to lpathak97/pycbc
that referenced
this pull request
Mar 13, 2024
* update parameters.py * fix cc issue * Update parameters.py * Update parameters.py * fix cc issues * Update parameters.py
acorreia61201
pushed a commit
to acorreia61201/pycbc
that referenced
this pull request
Apr 4, 2024
* update parameters.py * fix cc issue * Update parameters.py * Update parameters.py * fix cc issues * Update parameters.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ahnitz According to your good suggestion, I separated parts of the code from #4289 as separated PRs, this PR updates several parameter names for LISA.