Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live cleanup combine single fits #4450

Merged

Conversation

titodalcanton
Copy link
Contributor

Some cleanup I thought about when reviewing #4449. I broke the change down into a few commits to make checking easier if needed.

Copy link
Contributor

@GarethCabournDavies GarethCabournDavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this - I think some of these unused variables were from before the code was separated for combining / plotting, so thanks for that. One (very) minor suggestion, but this looks good to go

bin/live/pycbc_live_combine_single_fits Outdated Show resolved Hide resolved
@titodalcanton titodalcanton enabled auto-merge (squash) August 7, 2023 13:02
@titodalcanton titodalcanton merged commit 32e0b90 into gwastro:master Aug 7, 2023
36 checks passed
@titodalcanton titodalcanton deleted the live_cleanup_combine_single_fits branch August 7, 2023 15:14
PRAVEEN-mnl pushed a commit to PRAVEEN-mnl/pycbc that referenced this pull request Nov 3, 2023
* Docstring

* Remove unused variables

* Simplify loops/ifs

* Whitespace

* Logging tweaks

* Unnecessary f-strings

* Gareth's suggestion
titodalcanton added a commit to titodalcanton/pycbc that referenced this pull request Jan 16, 2024
* Docstring

* Remove unused variables

* Simplify loops/ifs

* Whitespace

* Logging tweaks

* Unnecessary f-strings

* Gareth's suggestion
bhooshan-gadre pushed a commit to bhooshan-gadre/pycbc that referenced this pull request Mar 4, 2024
* Docstring

* Remove unused variables

* Simplify loops/ifs

* Whitespace

* Logging tweaks

* Unnecessary f-strings

* Gareth's suggestion
acorreia61201 pushed a commit to acorreia61201/pycbc that referenced this pull request Apr 4, 2024
* Docstring

* Remove unused variables

* Simplify loops/ifs

* Whitespace

* Logging tweaks

* Unnecessary f-strings

* Gareth's suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants