Add pycbc support for the snowline sampler #4587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ahnitz Let me know when you want me to review this. |
|
@cdcapano Basically now, but I'm waiting for the CI to check if there are any issues introduced at that level. |
|
@cdcapano Can we merge this? I think there is one cc small thing I can fix, but otherwise, does this seem Ok to go? |
cdcapano
approved these changes
Feb 22, 2024
bhooshan-gadre
pushed a commit
to bhooshan-gadre/pycbc
that referenced
this pull request
Mar 4, 2024
* add support for snowline sampler * add to examples * add snowline to some docs, fixes * cc * fix * Update snowline.py * Update snowline.py * Update snowline.py * Update pool.py * Update snowline.py
lpathak97
pushed a commit
to lpathak97/pycbc
that referenced
this pull request
Mar 13, 2024
* add support for snowline sampler * add to examples * add snowline to some docs, fixes * cc * fix * Update snowline.py * Update snowline.py * Update snowline.py * Update pool.py * Update snowline.py
acorreia61201
pushed a commit
to acorreia61201/pycbc
that referenced
this pull request
Apr 4, 2024
* add support for snowline sampler * add to examples * add snowline to some docs, fixes * cc * fix * Update snowline.py * Update snowline.py * Update snowline.py * Update pool.py * Update snowline.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The snowline sampler (https://github.com/JohannesBuchner/snowline) is for unimodal distributions but may be good for some cases where we have very high SNR signals. (or want a quick initial estimate).