Cherry-picked commits for 2.1.5 #4634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptimizer (gwastro#4628) * adding non-optimizer specific options to args_to_string * correct formatting * simplifying if snr opt seed * Adding extra-opts arg * updating options in live example run.sh * restoring deleted space * removing redundant default * moving all snr optimizer options to snr_opt_extra_opts * updating argument help descriptions * removing snr_opt options from pycbc live * removing seed option from example * removing args_to_string * Actually, even simpler --------- Co-authored-by: Tito Dal Canton <tito.dalcanton@ijclab.in2p3.fr>
…stro#4636) * Update pycbc_live_combine_single_fits * logging warn -> warning deprecation
) * Improve how pycbc_live handles localization-only detectors LOD = localization-only detectors * Do not initialize single-detector FAR estimators for LOD * Only use triggering detectors for PSD var statistic * Correct the GraceDB annotation to explain which detectors contributed to the FAR and list the LOD * Only list triggering detectors in background dump filename * Code reformatting * Fixes * Fixes * Use attributes of event manager instead * Improve GraceDB annotation * Fix * Ignore loc-only detectors for rank > 0 * Further clarify which detectors are used only for localization * Main loop should go through the loc-only detectors only in rank 0
maxtrevor
approved these changes
Feb 20, 2024
titodalcanton
merged commit 4dc8cec
into
gwastro:v21_release_branch
35 of 39 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.