Avoid pegasus 5.0.7 #4651
Merged
Avoid pegasus 5.0.7 #4651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spxiwh I think we need to have the pegasus binaries also be version constrained e.g. the ones installed for the workflow tests. I don't recall how the lvk images are done, so might be worth checking if that is already pinned. |
|
@spxiwh Unless of course, the bug doesn't appear if you just use the old api version, but the newer planner version. I didn't test that myself. Does that work? |
|
This is something in the planner, so yeah, pinning the API isn't doing anything .... |
This reverts commit c9c915f.
|
@ahnitz This fixes the CI ... It should be reverted once the pegasus 5.0.8 release is made. I've asked LVK clusters not to upgrade to the 5.0.7 executables. Others using PyCBC+pegasus should also stick at 5.0.6 until a new release is available. |
ahnitz
approved these changes
Feb 24, 2024
bhooshan-gadre
pushed a commit
to bhooshan-gadre/pycbc
that referenced
this pull request
Mar 4, 2024
* Avoid pegasus 5.0.7 * Needs to be here, not in API requirements * Revert "Avoid pegasus 5.0.7" This reverts commit c9c915f.
lpathak97
pushed a commit
to lpathak97/pycbc
that referenced
this pull request
Mar 13, 2024
* Avoid pegasus 5.0.7 * Needs to be here, not in API requirements * Revert "Avoid pegasus 5.0.7" This reverts commit c9c915f.
acorreia61201
pushed a commit
to acorreia61201/pycbc
that referenced
this pull request
Apr 4, 2024
* Avoid pegasus 5.0.7 * Needs to be here, not in API requirements * Revert "Avoid pegasus 5.0.7" This reverts commit c9c915f.
spxiwh
added a commit
to spxiwh/pycbc
that referenced
this pull request
Apr 29, 2024
* Avoid pegasus 5.0.7 * Needs to be here, not in API requirements * Revert "Avoid pegasus 5.0.7" This reverts commit c9c915f.
spxiwh
added a commit
that referenced
this pull request
Apr 30, 2024
* Use more memory efficient reading of trigger files * Optimize pycbc_page_coincinfo * Optimize pycbc_page_coinc_snrchi * Optimize pycbc_page_snrchi * Optimize pycbc_plot_hist * Merge in 4662 * Avoid pegasus 5.0.7 (#4651) * Avoid pegasus 5.0.7 * Needs to be here, not in API requirements * Revert "Avoid pegasus 5.0.7" This reverts commit c9c915f. * use macos 12 (#4722) * use macos 12 * update --------- Co-authored-by: Alex Nitz <alex.nitz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version has a bug we don't want. The 5.0.8 release should be fine. Did I miss any file?