Fix sngls_minifollowup event selection/ordering [v23_release_branch] #4824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarethCabournDavies
added
the
v23_release_branch
spxiwh
approved these changes
Aug 2, 2024
GarethCabournDavies
force-pushed
the
v23_singles_minifollow_order
branch
from
59f44c3
to
adfdf81
Compare
GarethCabournDavies
merged commit 69874f0
into
gwastro:v23_release_branch
31 checks passed
|
I'm assuming from commit history and notes that this is on the v23 release branch. Please comment if not. |
spxiwh
removed
the
v23_release_branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that the sngls_minifollowup pages had essentially randomly chosen, and randomly-ordered events.
This was due to a bug introduced by an overzealous approach to the scope creep part of #4549 (my fault!)
This will also be fixed on the master branch in #4823
Standard information about the request
This is a bug fix
This change affects the offline search
This change changes result presentation
This change follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines
Contents
Return to using the mask_to_n_loudest_clustered_events function rather than trying anything too fancy
Testing performed
Currently running given latest version
Run pycbc_sngl_minifollow and check by printing values that the top events are in the right order, and that the are the highest-statistic events
The author of this pull request confirms they will adhere to the code of conduct