pycbc_plot_bank_corner improvements for live #4849
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements are needed for the fits plotting.
This allows log ranges to be used for all parameters including the colorbar parameter, and also adds the IFO to the title of the plot when it is called by the live supervisor
Standard information about the request
This is a new feature
This change affects: plotting from the live search
This change follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines
Motivation
Before these changes, we would have to use log(param) in the --parameters argument. This leads to unwieldy labels and non-intuitive axis tick values
Contents
create_multidim_plot
, and use manual normalisation objects rather than the default linear normTesting performed
See https://ldas-jobs.ligo.caltech.edu/~gareth.cabourndavies/testoutput/fit_plots_improvements/L1-FIT_OVER_PARAM-2024_08_07.png for a plot which uses log scale in x axis and linear elsewhere.
https://ldas-jobs.ligo.caltech.edu/~gareth.cabourndavies/testoutput/fit_plots_improvements/L1-FIT_BY_TEMPLATE-2024_08_07.png uses log scale on x and y, and also on the color scale
Other plots in that directory show:
where 2 parameters are used, with a histogram (special case where the bottom right histogram plot is rotated 90 degrees)
where 3 parameters are used, with a histogram
where no log-scaled parameters are used
The author of this pull request confirms they will adhere to the code of conduct