Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pycbc_plot_bank_corner improvements for live #4849

Merged

Conversation

GarethCabournDavies
Copy link
Contributor

@GarethCabournDavies GarethCabournDavies commented Aug 9, 2024

Improvements are needed for the fits plotting.
This allows log ranges to be used for all parameters including the colorbar parameter, and also adds the IFO to the title of the plot when it is called by the live supervisor

Standard information about the request

This is a new feature
This change affects: plotting from the live search

This change follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines

Motivation

Before these changes, we would have to use log(param) in the --parameters argument. This leads to unwieldy labels and non-intuitive axis tick values

Contents

  • Add two options to pycbc_plot_bank_corner for log parameters and log-colormap
  • check that the log-parameters are sensible
  • Modify the logic for extending the axes so that if it is on a log scale, this will not break things by becomeing a negative value
  • pass the colorbar argument into create_multidim_plot, and use manual normalisation objects rather than the default linear norm
  • set semilogy and semilogx on the axis dictionary values when appropriate
  • I've also added the IFO into the plot title when it is called by the supervisor script.

Testing performed

See https://ldas-jobs.ligo.caltech.edu/~gareth.cabourndavies/testoutput/fit_plots_improvements/L1-FIT_OVER_PARAM-2024_08_07.png for a plot which uses log scale in x axis and linear elsewhere.
https://ldas-jobs.ligo.caltech.edu/~gareth.cabourndavies/testoutput/fit_plots_improvements/L1-FIT_BY_TEMPLATE-2024_08_07.png uses log scale on x and y, and also on the color scale
Other plots in that directory show:

  • where 2 parameters are used, with a histogram (special case where the bottom right histogram plot is rotated 90 degrees)

  • where 3 parameters are used, with a histogram

  • where no log-scaled parameters are used

  • The author of this pull request confirms they will adhere to the code of conduct

Copy link
Contributor

@maxtrevor maxtrevor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@maxtrevor maxtrevor merged commit e9bdd6a into gwastro:master Aug 9, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants