Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loglikelihood_function argument in nessai sampler #4860

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mj-will
Copy link
Contributor

@mj-will mj-will commented Aug 29, 2024

Standard information about the request

This is a: bug fix

This change affects: inference

This change changes: scientific output

This change: has appropriate unit tests, follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines

This change will: fix a bug that prevents an option from being used

Motivation

The current implementation does not allow the user to specify the loglikelihood-function. Instead it raises an error:

RuntimeError: Config contains unknown options: {'loglikelihood-function'}

Contents

This happens because the sampler class checks the specified options against a list of valid options but this did not account for the pycbc-specific option loglikelihood-function. This PR adds loglikelihood-function to the set of options pycbc-specific options that are allowed.

Links to any issues or associated PRs

N/A

Testing performed

I've run the LISA injection example with a modified config where loglikelihood-function=loglr

Additional notes

  • The author of this pull request confirms they will adhere to the code of conduct

@mj-will mj-will force-pushed the fix-nessai-loglikelihood-function branch from fc4d1f1 to 1124b2b Compare September 5, 2024 07:39
@mj-will
Copy link
Contributor Author

mj-will commented Sep 5, 2024

@HumphreyWang were you able to test this with your problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant