Improved pygrb missed/quiet injection tables job handler #4877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spxiwh
approved these changes
Sep 17, 2024
pycbc/workflow/grb_utils.py
Outdated
| node = PlotExecutable(workflow.cp, exec_name, | ||
| ifos=workflow.ifos, out_dir=out_dir, | ||
| tags=tags+extra_tags).create_node() | ||
| # Pass the bank-file | ||
| node.add_input_opt('--bank-file', resolve_url_to_file(bank_file)) |
There was a problem hiding this comment.
Same comment here with bank_file, pass File objects around, not URLs. There are potential failure modes with file handling here if resolve_url_to_file doesn't realise it is the same file every time.
pycbc/workflow/grb_utils.py
Outdated
| # Pass the bank-file | ||
| node.add_input_opt('--bank-file', resolve_url_to_file(bank_file)) | ||
| # Offsource input file (or equivalently trigger file for injections) | ||
| offsource_file = resolve_url_to_file(off_file) |
pycbc/workflow/grb_utils.py
Outdated
| 'sngl-snr-threshold', 'null-grad-thresh', 'null-grad-val']: | ||
| if workflow.cp.has_option('workflow', opt): | ||
| node.add_opt('--'+opt, workflow.cp.get('workflow', opt)) | ||
| seg_filelist = FileList([resolve_url_to_file(sf) for sf in seg_files]) |
pycbc/workflow/grb_utils.py
Outdated
| fm_file = configparser_value_to_file(workflow.cp, | ||
| 'injections-'+inj_set, | ||
| 'found-missed-file') | ||
| fm_file = resolve_url_to_file(inj_file) |
There was a problem hiding this comment.
Why would this not already be a file object here???
pycbc/workflow/grb_utils.py
Outdated
| if on_file is not None: | ||
| src_type = 'onsource-trig' | ||
| # Onsource input file (passed as File instance) | ||
| onsource_file = resolve_url_to_file(on_file) |
|
@spxiwh, I followed up on your comments, thanks. I reran the post-processing portion of the run and successfully produced a new webpage which looks like the original one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves how jobs are added to the PyGRB workflow to create tables with "quiet-found" and "missed-found injections". The function is (hopefully) cleaner and it handles its inputs more appropriately.
Standard information about the request
This is an improvement of an existing feature.
This change affects: PyGRB
This change changes: result presentation
Links to any issues or associated PRs
This change is the 4th PR of a series started with #4872. It should be the last one for
grb_utils.py.Testing performed
As for the previous 3 PRs, a complete webpage example is available here, but the full webpage will be reproducible only once all workflow changes are on master.