Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pygrb skygrid plot #4888

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

pannarale
Copy link
Contributor

@pannarale pannarale commented Sep 21, 2024

Standard information about the request

This is an aesthetic change to the PyGRB sky grid plot.

This change affects: PyGRB

This change changes: result plotting

This change will: make sure that the sky grid plot is not trimmed, show grid lines on the plot, and provide it with a caption.

Motivation

#4784.

Testing performed

https://ldas-jobs.ligo.caltech.edu/~francesco.pannarale/LVC/pygrb_sep2024_2/

  • The author of this pull request confirms they will adhere to the code of conduct

@pannarale pannarale added the PyGRB PyGRB development label Sep 21, 2024
@pannarale pannarale self-assigned this Sep 21, 2024
@pannarale pannarale mentioned this pull request Sep 21, 2024
Copy link
Contributor

@sebastiangomezlopez sebastiangomezlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These cosmetic changes look good to me.

@sebastiangomezlopez sebastiangomezlopez merged commit 6142c52 into gwastro:master Sep 23, 2024
30 checks passed
@pannarale pannarale deleted the tight_sky_grid_plot branch September 24, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyGRB PyGRB development
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants