Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [hopefully] documentation failure #4901

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Fix [hopefully] documentation failure #4901

merged 1 commit into from
Oct 7, 2024

Conversation

spxiwh
Copy link
Contributor

@spxiwh spxiwh commented Oct 7, 2024

The CI is failing again. Looking over the logs, Sphinx suggests that we just remove the line removed here (https://github.com/gwastro/pycbc/actions/runs/11219860463/job/31186751487?pr=4899).

@spxiwh spxiwh requested a review from ahnitz October 7, 2024 19:44
@ahnitz
Copy link
Member

ahnitz commented Oct 7, 2024

@spxiwh The error message certainly seems clear. I think this change is fine. Once the docs build and one can double check what the page looks like (this is uploaded as an artifact in the CI), I think this can be merged.

Copy link
Member

@ahnitz ahnitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please check that the uploaded docs look correct after this change.

@spxiwh
Copy link
Contributor Author

spxiwh commented Oct 7, 2024

The page uploaded as an artefact in the CI here looks fine.

@spxiwh spxiwh merged commit c82b88b into master Oct 7, 2024
59 checks passed
@spxiwh spxiwh deleted the spxiwh-patch-1 branch October 7, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants