Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes extend the configuration options of the build, which allows Gentoo authors to drop their patches (gentoo/guru@ffc7513).
This PR changes the logic by which compiler-specific warnings are applied. From the commit message:
As a result, we now may pass unknown flags to the compiler as long as they don't cause the build to crash (by themselves).
On the plus side, this approach allows us not to keep track of which compiler support which flags and we don't rely on the existence of the
gcc
andclang
binaries anymore.Its usage is discouraged in favor of their target-prefixed variants for cross-compilation, as they may accidentally compile for the host instead of the target.
The same argument applies for the usage of
pkg-config
vs. a freely configurablePKG_CONFIG
.