Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add density option for histograms #380

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

iaraota
Copy link
Collaborator

@iaraota iaraota commented Oct 20, 2023

This PR introduces the density matplotlib property to GWSumm.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #380 (28ea0ed) into master (f658c15) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #380   +/-   ##
=======================================
  Coverage   50.25%   50.25%           
=======================================
  Files          60       60           
  Lines        8670     8670           
=======================================
  Hits         4357     4357           
  Misses       4313     4313           
Flag Coverage Δ
Linux 50.25% <ø> (ø)
python3.10 50.25% <ø> (ø)
python3.7 49.45% <ø> (ø)
python3.8 50.25% <ø> (ø)
python3.9 50.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
gwsumm/plot/utils.py 80.77% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@iaraota iaraota requested a review from eagoetz November 1, 2023 14:29
@eagoetz
Copy link
Collaborator

eagoetz commented Nov 1, 2023

@iaraota Do we still need the density option if we're going to make a new type of plot in gwsumm to support the feature request?

@eagoetz eagoetz added this to the 2.2.0 milestone Nov 1, 2023
Copy link
Collaborator

@eagoetz eagoetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eagoetz eagoetz merged commit 330fa6d into gwpy:master Nov 1, 2023
11 of 12 checks passed
@iaraota iaraota deleted the add_density branch April 23, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants