Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add countries props for input phone component #872

Merged
merged 7 commits into from
Feb 5, 2025

Conversation

invmmartins
Copy link
Contributor

JIRA Issue

Description 📄

The goal of this PR is to add the prop countries so the child component of input phone can filter the countries options to show in the input phone field.

[Enter the description of your changes]

Platforms 📲

  • Web
  • Mobile

Type of change 🔍

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 🧪

[Enter the tips to test this PR]

  • Unit Test
  • Snapshot Test

Checklist: 🔍

  • My code follows the contribution guide of this project Contributing Guide
  • Layout matches design prototype: FIGMA
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots 📸

image

[Upload your screenshots here]

Before After

add countries props so the input only show and format the given countries
add test for new input phone props and make sure that old tests still works
add docs for countries props on input phone web
@MicaelRodrigues MicaelRodrigues merged commit efe299d into master Feb 5, 2025
4 checks passed
@MicaelRodrigues MicaelRodrigues deleted the feat/countries-input-phone branch February 5, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants