Fixed marking cells with bombs for example mines
#792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earby unmarket cells by middle mouse click and count scores.
All state moved to model (flag marks) therefore `border::view::Overlay` became meaningless type and was removed. Now method `BoardView::draw()` using data about cells from model.
gyscos
reviewed
Jun 17, 2024
cursive/examples/mines/board/view.rs
Outdated
| (Closed, _, false) => " □", | ||
| (Marked, _, false) => " ■", | ||
| (Opened, Free(n), false) | (_, Free(n), true) => [" ", " 1", " 2", " 3", " 4", " 5", " 6", " 7", " 8"][n], | ||
| (Opened, Bomb, false) | (_, Bomb, true) => "\u{01F4A3} " |
There was a problem hiding this comment.
From my tests the 💣 character is rendered double-width, so no need for a space after?
There was a problem hiding this comment.
I agree, I removed redundant space
Co-authored-by: Alexandre Bury <alexandre.bury@gmail.com>
Co-authored-by: Alexandre Bury <alexandre.bury@gmail.com>
Co-authored-by: Alexandre Bury <alexandre.bury@gmail.com>
Co-authored-by: Alexandre Bury <alexandre.bury@gmail.com>
Co-authored-by: Alexandre Bury <alexandre.bury@gmail.com>
Co-authored-by: Alexandre Bury <alexandre.bury@gmail.com>
Co-authored-by: Alexandre Bury <alexandre.bury@gmail.com>
Co-authored-by: Alexandre Bury <alexandre.bury@gmail.com>
|
@gyscos, PR is ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually I don't know goal of this example and would this changes acceptable.
For fixing
auto_revealbehaviour, it needs information about marked cells in model.When
Markedstate moved to border's model. All data about cells state become in the model cells, therefore much easy was remove synchronization cell's state between view and model and cell's state from view and just share cells state from model to view (and draw it).This PR depends on #790