Refactor random_battle_scene and random_berries#272
Refactor random_battle_scene and random_berries#272google-labs-jules[bot] wants to merge 1 commit intomainfrom
Conversation
- Introduced `get_random_file_from_directory` in `src/Ankimon/utils.py`. - Refactored `random_battle_scene` to use the new generic function. - Removed unused `random_berries` function. - Added type hinting and error logging.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Merged redundant logic in
random_battle_sceneandrandom_berriesinto a new generic functionget_random_file_from_directory. This reduces code duplication and improves maintainability. The new function includes error handling and logging usingmw.logger.log_and_showinfo. The unusedrandom_berriesfunction was removed. Verified with custom unit tests (temporarily created) and existing integrity tests.PR created automatically by Jules for task 13231113103296841066 started by @h0tp-ftw