fix: sprite disappears in pokemon details when changing pages#298
Open
abr-Projects wants to merge 2 commits intoh0tp-ftw:mainfrom
Open
fix: sprite disappears in pokemon details when changing pages#298abr-Projects wants to merge 2 commits intoh0tp-ftw:mainfrom
abr-Projects wants to merge 2 commits intoh0tp-ftw:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the Pokemon sprite and details disappear when changing PC pages after showing Pokemon details. The issue occurred because refresh_gui() clears and rebuilds the entire layout, destroying the details panel widget.
Changes:
- Replaced
self.pokemon_details_layoutwithself.selected_pokemonto track which Pokemon's details should be displayed - Modified
create_gui()to reconstruct the details panel from stored Pokemon data whenrefresh_gui()is called - Simplified
show_pokemon_details()to just store the Pokemon and trigger a GUI refresh - Updated
on_window_close()to clear the selected Pokemon reference instead of the details layout
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue #295
Cause:
refresh_gui()clears the entire main layout , recursively deleting all widgets.go_to_box()callsrefresh_gui(), so when page changes the detail panel is deleted. the ui maintains a reference to a layout that is invalid, resulting in missing elementsSolution:
Introduce
self.selected_pokemonto track the current pokemon in view. So whenrefresh_gui()is called the detail panel is reconstructed withself.selected_pokemon