feat: Backport Team Pokémon Overview feature to stable addon#299
Open
Unlucky-Life wants to merge 2 commits intomainfrom
Open
feat: Backport Team Pokémon Overview feature to stable addon#299Unlucky-Life wants to merge 2 commits intomainfrom
Unlucky-Life wants to merge 2 commits intomainfrom
Conversation
- Introduced a new module `overview_team.py` to build and inject a Pokémon team grid into the Deck Browser and Deck Overview pages. - Added hooks for rendering the team grid in both views, gated by a new user setting `gui.team_deck_view`. - Implemented a settings toggle in the "Styling" group, with defaults set in `config.json` and `settings.py`. - Enhanced resource management by adding `pokeball_path` and a utility function `png_to_base64` for embedding images. - Ensured graceful failure when data files are missing, preventing crashes. - Updated language files for internationalization support of the new setting. - Created an empty `__init__.py` to make `gui_classes` a proper Python package. - Comprehensive testing checklist included to verify functionality and stability.
h0tp-ftw
reviewed
Feb 6, 2026
Owner
h0tp-ftw
left a comment
h0tp-ftw
left a comment
There was a problem hiding this comment.
This is our first time dealing with the Decks overview GUI, which is used by many addons. Would like to know from @thepeacemonk if this kind of implementation suits their or other GUI addons.
| :pyobj:`aqt.gui_hooks.overview_will_render_content`. | ||
|
|
||
| Args: | ||
| overview: The :class:`aqt.overview.Overview` instance. |
Owner
There was a problem hiding this comment.
needs restart, might be worth it to put a restart for changes to take effect in settings
| mw.translator = translator | ||
| mw.settings_obj = settings_obj | ||
|
|
||
| from .gui_classes.overview_team import * |
| effectiveness_chart_file_path = addon_dir / "addon_files" / "eff_chart.json" | ||
| table_gen_id_html_path = addon_dir / "addon_files" / "table_gen_id.html" | ||
| icon_path = addon_dir / "addon_files" / "pokeball.png" | ||
| pokeball_path = addon_dir / "addon_files" / "pokeball.png" |
Owner
There was a problem hiding this comment.
Suggested change
| pokeball_path = addon_dir / "addon_files" / "pokeball.png" |
Owner
There was a problem hiding this comment.
ideally every pokeball_path mention should be changed to icon_path or v.v.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
overview_team.pyto build and inject a Pokémon team grid into the Deck Browser and Deck Overview pages.gui.team_deck_view.config.jsonandsettings.py.pokeball_pathand a utility functionpng_to_base64for embedding images.__init__.pyto makegui_classesa proper Python package.