Fix XP calculation to handle None values and set default XP to 0#300
Open
Unlucky-Life wants to merge 3 commits intomainfrom
Open
Fix XP calculation to handle None values and set default XP to 0#300Unlucky-Life wants to merge 3 commits intomainfrom
Unlucky-Life wants to merge 3 commits intomainfrom
Conversation
|
I also fixed that issue in a PR of mine and didn't see it being fixed 2 weeks ago already :D Looks good to me, but I am unable to approve. Are contributors who have permission to do so aware of your PR and somewhat active? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #297 of mainpokemon xp not being set.
Solution -