Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue #302 #247
This pull request refactors the pokemon pc box ui to make the pokemon grid responsive. The main changes include separating the grid refresh logic from the overall gui construction, adding dynamic resizing for the grid, and debounced refreshes to optimize rendering during window resizing.
refresh_pokemon_gridis also called whenever pokemon is added or evolved, to keep the pokemon grid in sync.Changes:
refresh_pokemon_gridmethod, allowing the grid to be updated independently from the rest of the gui.QTimerto avoid excessive refreshes during window resizing.QScrollArea, for the handling of shrinking windows and ensuring that only fully visible slots are displayed.refresh_pokemon_gridmethod calls to functions that manipulate the pokemon collection.