bugfix: reset the window title to 'Ankimon Window' after every catch/defeat

[MrElektronz]

After catching or defeating a pokemon the "Ankimon Window" title is not being reset.

Current state:

State with the PR:

[gemini-code-assist]

Summary of Changes

Hello @MrElektronz, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a user interface inconsistency where the Ankimon window title would not revert to its default state after a Pokémon was caught or defeated. By encapsulating the title reset logic into a dedicated method and integrating it into the relevant UI actions, the change ensures that the application's window title consistently displays 'Ankimon Window' after key interactions.

Highlights

• New Helper Method: Introduced a new private method _reset_window_title to centralize the logic for setting the main window's title to 'Ankimon Window'.
• Initial Window Title Setup: Updated the init_ui function to use the new _reset_window_title method, ensuring the window title is correctly set upon application initialization.
• Post-Action Title Reset: Modified the qconnect calls for the catch and defeat buttons to invoke _reset_window_title after mw.catchpokemon() and mw.defeatpokemon() respectively, resolving the issue where the title was not resetting after these events.

Changelog

• src/Ankimon/pyobj/test_window.py
  • Replaced direct window title setting with a new helper method in init_ui.
  • Wrapped mw.catchpokemon() and mw.defeatpokemon() calls with the new title reset method.
  • Added _reset_window_title method to manage window title updates and optionally execute a callback.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request addresses an issue where the window title was not being reset after catching or defeating a Pokémon. The changes introduce a new private method _reset_window_title to handle setting the window title and optionally executing a callback function. This method is then used in init_ui and when connecting signals to the catch and defeat buttons. The changes are logical and directly resolve the reported bug.