feat: support string of format num1-num2 for cards_per_round to all r…

[MrElektronz]

#310
Implemented this suggestion to allow a random cards_per_round value in range

[gemini-code-assist]

Summary of Changes

Hello @MrElektronz, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the flexibility of the cards_per_round setting by introducing support for dynamic, randomized values. Users can now specify a range (e.g., "1-3") instead of a fixed number, allowing the system to randomly select the number of cards per battle round within that range. This change improves the user experience by offering more varied gameplay without requiring manual adjustments to the setting.

Highlights

• Dynamic Cards Per Round: Introduced support for a dynamic cards_per_round setting, allowing users to specify a range (e.g., "1-3") from which a random number of cards will be selected for each battle round.
• New Helper Function: Implemented a new helper function, _get_cards_per_round, responsible for parsing the battle.cards_per_round setting, handling both fixed integer values and the new 'min-max' string format.
• Settings UI Update: Modified the settings window's save logic to correctly store the cards_per_round value as either an integer or a string, depending on whether a range or a single number is provided.
• Default Value Adjustment: Changed the default battle.cards_per_round value in the configuration from an integer to a string to ensure compatibility with the new parsing mechanism.
• User Guidance: Updated the description for the battle.cards_per_round setting to inform users about the new 'a-b' format for dynamic values.

Changelog

• src/Ankimon/init.py
  • Modified the on_review_card function to utilize the new _get_cards_per_round helper function for determining cards per round.
  • Added the _get_cards_per_round function to parse the battle.cards_per_round setting, supporting both integer and 'min-max' string formats, and returning a random integer for range inputs.
• src/Ankimon/lang/setting_description.json
  • Updated the description for the battle.cards_per_round setting to include instructions for using the new 'a-b' dynamic range format.
• src/Ankimon/pyobj/settings.py
  • Changed the default value of battle.cards_per_round from an integer 2 to a string "2" to align with the new flexible parsing logic.
• src/Ankimon/pyobj/settings_window.py
  • Implemented special handling within the on_save method for battle.cards_per_round to correctly save user input as either an integer or a 'num1-num2' string, including validation for the range format.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a nice feature to allow a random number of cards per round by specifying a range (e.g., '1-3') in the settings. The changes span across the settings definition, the settings UI, and the core logic that uses this value. While the feature is well-implemented, I've found a critical issue in the parsing logic that could lead to the addon crashing during review. I've also included a suggestion to improve the code's conciseness in the settings window. Please see my detailed comments.