feat(#9): with

h1alexbel · Jul 8, 2024 · 35bd496 · 35bd496
1 parent a04a439
commit 35bd496
Showing 1 changed file with 23 additions and 23 deletions.
diff --git a/sr-data/src/sr_data/tasks/collect.py b/sr-data/src/sr_data/tasks/collect.py
@@ -48,29 +48,29 @@ def main(config=default):
             --tokens {config["tokens"]}
     """
     try:
-        process = subprocess.Popen(
-            cmd,
-            shell=True,
-            stdout=subprocess.PIPE,
-            stderr=subprocess.PIPE,
-            text=True
-        )
-        while True:
-            output = process.stdout.readline()
-            if output == '' and process.poll() is not None:
-                break
-            if output:
-                print(output.strip())
-        err = process.stderr.read()
-        if err:
-            print(f"Error: {err.strip()}")
-        process.wait()
-        if process.returncode != 0:
-            raise subprocess.CalledProcessError(
-                process.returncode,
+        with subprocess.Popen(
                 cmd,
-                output=process.stdout.read(),
-                stderr=err
-            )
+                shell=True,
+                stdout=subprocess.PIPE,
+                stderr=subprocess.PIPE,
+                text=True
+        ) as process:
+            while True:
+                output = process.stdout.readline()
+                if output == '' and process.poll() is not None:
+                    break
+                if output:
+                    print(output.strip())
+            err = process.stderr.read()
+            if err:
+                print(f"Error: {err.strip()}")
+            process.wait()
+            if process.returncode != 0:
+                raise subprocess.CalledProcessError(
+                    process.returncode,
+                    cmd,
+                    output=process.stdout.read(),
+                    stderr=err
+                )
     except subprocess.CalledProcessError as e:
         print(f"Something went wrong: {e.stderr}")