Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#180): cluster models to sr-train #187

Merged
merged 4 commits into from
Oct 30, 2024
Merged

feat(#180): cluster models to sr-train #187

merged 4 commits into from
Oct 30, 2024

Conversation

h1alexbel
Copy link
Owner

@h1alexbel h1alexbel commented Oct 30, 2024

In this pull I've moved clustering models and related tests, from sr-data to sr-train package.

closes #180
History:


PR-Codex overview

This PR focuses on restructuring the project to include a new module for clustering models and updating relevant dependencies, scripts, and test cases to accommodate this change.

Detailed summary

  • Updated docstrings to reflect "Clustering models."
  • Added sr-train directory to Dockerfile and pyproject.toml.
  • Changed import paths in test files to use models.cluster.
  • Updated test case descriptions.
  • Added scikit-learn dependency to sr-train.
  • Created a new cluster task in sr-train.
  • Modified commands in justfile to reference sr-train.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@h1alexbel
Copy link
Owner Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Oct 30, 2024

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here.

@rultor rultor merged commit 59f30a1 into master Oct 30, 2024
17 checks passed
@rultor
Copy link
Collaborator

rultor commented Oct 30, 2024

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 11min).

@h1alexbel h1alexbel deleted the 180 branch October 30, 2024 12:49
@h1alexbel
Copy link
Owner Author

@rultor release, tag is 0.0.14

@rultor
Copy link
Collaborator

rultor commented Oct 30, 2024

@rultor release, tag is 0.0.14

@h1alexbel OK, I will release it now. Please check the progress here.

@rultor
Copy link
Collaborator

rultor commented Oct 30, 2024

@rultor release, tag is 0.0.14

@h1alexbel Done! FYI, the full log is here (took me 18min).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

place clustering models from sr-data into sr-train
2 participants