Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#189): apply(bool) if repos are not empty #191

Merged
merged 4 commits into from
Nov 5, 2024
Merged

fix(#189): apply(bool) if repos are not empty #191

merged 4 commits into from
Nov 5, 2024

Conversation

h1alexbel
Copy link
Owner

@h1alexbel h1alexbel commented Nov 4, 2024

ref #189


PR-Codex overview

This PR focuses on enhancing the handling of repositories with null headings in the extraction process, updating the test suite, and making adjustments to the build configuration.

Detailed summary

  • Added a new CSV file to-extract-null-headings.csv for testing.
  • Updated the build.yml to use macos-13.
  • Introduced a new test test_skips_repo_with_null_headings in test_extract.py.
  • Adjusted the extraction logic in extract.py to drop rows with null headings before further processing.
  • Ensured that mcw is only calculated if headings exists in the DataFrame.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@h1alexbel
Copy link
Owner Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Nov 5, 2024

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here.

@rultor rultor merged commit a963901 into master Nov 5, 2024
17 checks passed
@rultor
Copy link
Collaborator

rultor commented Nov 5, 2024

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 9min).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants