Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ expose http timeout and ssl context options on the entry functions #101

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

zoido
Copy link
Collaborator

@zoido zoido commented Jul 25, 2024

It turned out that the support was already done on the lower level but never exposed on the entry functions level.

fix: use inherited constructor in sync Client

feat: use default ssl context by default

RESOLVES #100

@zoido zoido self-assigned this Jul 25, 2024
@zoido zoido changed the title feat: ✨ expose http timeout and ssl_context options on the entry functions feat: ✨ expose http timeout and ssl context options on the entry functions Jul 25, 2024
@zoido zoido requested review from orendain and johnygomez July 25, 2024 14:33
@zoido zoido marked this pull request as draft July 25, 2024 14:34
@zoido zoido removed request for orendain and johnygomez July 25, 2024 14:34
…tions

fix: use nase inherited constructor in sync `Client`

feat: use default ssl context by default

RESOLVES #100
@zoido zoido marked this pull request as ready for review July 25, 2024 14:42
@zoido zoido requested review from johnygomez and orendain July 25, 2024 14:42
Copy link
Member

@johnygomez johnygomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Copy link
Member

@orendain orendain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@zoido zoido added this pull request to the merge queue Jul 25, 2024
Merged via the queue into main with commit f63a371 Jul 25, 2024
15 checks passed
@zoido zoido deleted the lp/ssl-context branch July 25, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for custom SSL context and read system certs by default
3 participants