Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 pass the timeout and ssl_context to the httpx #105

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

zoido
Copy link
Collaborator

@zoido zoido commented Nov 11, 2024

Use the prepared client factory with all of the options passed instead of direct call to httpx.
I have no explanation why it was the way it was.

RESOLVES #104

Use the prepared client factory instead of direct call to httpx.
I have no explanation why it was the way it was.

RESOLVES #104
@zoido zoido self-assigned this Nov 11, 2024
@zoido zoido marked this pull request as ready for review November 11, 2024 09:57
Copy link
Member

@johnygomez johnygomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoido zoido added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit 106dbf2 Nov 11, 2024
15 checks passed
@zoido zoido deleted the lp/pass-ctx branch November 11, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] SSL context not passed to httpx
2 participants