Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix characteristic discovery with no descriptors. #863

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

gkoh
Copy link
Contributor

@gkoh gkoh commented Jan 16, 2025

Avoid discovery of descriptors if there are no handles remaining, fixes #861.

This reinstates the check removed in 853241b.

Avoid discovery of descriptors if there are no handles remaining.

This reinstates the check removed in 853241b.
@gkoh gkoh changed the title Fix characteristic discovery with no descriptors (#861) Fix characteristic discovery with no descriptors. Jan 16, 2025
@h2zero
Copy link
Owner

h2zero commented Jan 16, 2025

Thanks!, looks like I over-pruned 😄

@h2zero h2zero merged commit 3081bc1 into h2zero:master Jan 16, 2025
31 checks passed
h2zero pushed a commit that referenced this pull request Jan 27, 2025
Avoid discovery of descriptors if there are no handles remaining.

This reinstates the check removed in 853241b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NimBLEClient::discoverAttributes() always(?) fails
2 participants