test(phpstan): add annotation

phpstan.neon

@@ -5,7 +5,6 @@ parameters:
 		- tests/src
 	bootstrapFiles:
 		- tests/bootstrap.php
-	checkGenericClassInNonGenericObjectType: false
 	ignoreErrors:
 		- "#^Call to an undefined method Mockery\\.*#"
 

src/RatingList/RatingList.php

@@ -33,6 +33,9 @@ public function getRequest(): ?DateTimeImmutable
 	}
 
 
+	/**
+	 * @return ArrayIterator<string, Property>
+	 */
 	public function getIterator(): ArrayIterator
 	{
 		return new ArrayIterator($this->properties);

tests/src/ExchangeTest.php

@@ -15,6 +15,7 @@
 use h4kuna\Exchange\RatingList\CacheEntity;
 use h4kuna\Exchange\RatingList\RatingList;
 use h4kuna\Exchange\RatingList\RatingListCache;
+use Mockery\MockInterface;
 use Tester\Assert;
 use Tester\TestCase;
 
@@ -96,13 +97,15 @@ private static function createExchange(): Exchange
 			'USD' => new Property(10, 135, 'USD'),
 		]);
 
-		$ratingListCache = mock(CacheLocking::class)
-			->makePartial();
+		/** @var CacheLocking&MockInterface $ratingListCache */
+		$ratingListCache = mock(CacheLocking::class);
+		$ratingListCache->makePartial();
 		$ratingListCache->shouldReceive('load')
 			->andReturn(null);
 		$ratingListCache->shouldReceive('get')
 			->andReturn($ratingList, $ratingList2);
 
+		/** @var SourceDownloadInterface&MockInterface $sourceDownload */
 		$sourceDownload = mock(SourceDownloadInterface::class);
 
 		$ratingListCache = new RatingListCache($ratingListCache, $sourceDownload);

tests/src/RatingList/RatingListCacheTest.php

@@ -14,7 +14,7 @@
 use h4kuna\Exchange\RatingList\CacheEntity;
 use h4kuna\Exchange\RatingList\RatingList;
 use h4kuna\Exchange\RatingList\RatingListCache;
-use Mockery\Mock;
+use Mockery\MockInterface;
 use Psr\Http\Client\ClientExceptionInterface;
 use Psr\SimpleCache\CacheInterface;
 use Tester\Assert;
@@ -70,8 +70,9 @@ public function testRebuild(): void
 		$ratingList = self::createRatingList();
 		$ratingList2 = self::createRatingList();
 
-		$cacheLocking = mock(CacheLocking::class)
-			->makePartial();
+		/** @var MockInterface&CacheLocking $cacheLocking */
+		$cacheLocking = mock(CacheLocking::class);
+		$cacheLocking->makePartial();
 		$cacheLocking->shouldReceive('get')
 			->with('h4kuna.Exchange.Driver.Cnb.Day.ttl')
 			->andReturn($ratingList, $ratingList2);
@@ -148,29 +149,33 @@ public function testFatalFailedBuild(): void
 
 
 	/**
-	 * @return Mock&SourceDownloadInterface
+	 * @return MockInterface&SourceDownloadInterface
 	 */
 	private static function createSourceDownload()
 	{
-		$source = mock(SourceDownloadInterface::class)
-			->makePartial();
+		/** @var MockInterface&SourceDownloadInterface $source */
+		$source = mock(SourceDownloadInterface::class);
+		$source->makePartial();
 
 		return $source;
 	}
 
 
 	/**
-	 * @return Mock&CacheInterface
+	 * @return MockInterface&CacheInterface
 	 */
 	private static function createCache()
 	{
-		return mock(CacheInterface::class)
-			->makePartial();
+		/** @var MockInterface&CacheInterface $cache */
+		$cache = mock(CacheInterface::class);
+		$cache->makePartial();
+
+		return $cache;
 	}
 
 
 	/**
-	 * @return Mock&CacheLocking
+	 * @return MockInterface&CacheLocking
 	 */
 	private static function createCacheLocking(
 		RatingList $ratingList,
@@ -189,6 +194,7 @@ private static function createCacheLocking(
 			return true;
 		};
 
+		/** @var CacheLocking&MockInterface $cacheLocking */
 		$cacheLocking = mock(CacheLocking::class)
 			->makePartial();
 		$cacheLocking->shouldReceive('set')