Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shiny skeleton #6

Merged
merged 3 commits into from
Nov 9, 2020
Merged

Shiny skeleton #6

merged 3 commits into from
Nov 9, 2020

Conversation

bonschorno
Copy link
Contributor

Hi everyone!
I created a Shiny skeleton with Leaflet (see issues #3 & #5 ). Everything runs locally, so you can try it out yourself. Also, as the underlying dataset is an sf file, it's very easy to add additional data via the ISO 3 codes (regarding issues #2 & #4).

@dariomeili
Copy link
Contributor

Nice! Would you have some time to walk me/us through it quickly? Since I've never really worked with neither leaflet nor shiny before, I'm not sure I get what it's doing.

@mbannert
Copy link
Contributor

mbannert commented Nov 6, 2020

Looking from the outside in, giving a little review here:

  • think about pushing your .Rproj files. Might wanna add to .gitignore as this can be individual
  • also switch your default LaTeX engine to knitr (sweave is a bit old fashioned, might run into trouble when rendering markdown to .pdf) Won't matter for this project, rather general advice.
  • consider using ui.R and server.R instead of a single file.

@dariomeili dariomeili merged commit a330359 into h4sci:main Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants