Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hearing date and date accepted sorting #133

Merged
merged 2 commits into from
May 14, 2024

Conversation

wesleytam88
Copy link
Collaborator

Developer: Wesley Tam

Closes #129

Pull Request Summary

Fixed sorting by hearing date and date accepted

Modifications

tableColumns.tsx: added custom sorting functions for the date fields

Testing Considerations

Manually checked if sorting was correct

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Assign reviewers

Screenshots/Screencast

sort_by_hearing_date
sort_by_date_accepted

@wesleytam88 wesleytam88 linked an issue May 13, 2024 that may be closed by this pull request
1 task
Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ecologistics-web-scraper ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 10:26pm

Copy link
Collaborator

@ryanchansf ryanchansf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great Wesley! Good move making a custom sorting function, ensures ease of mind when it comes to something like this. Nice work!

@ryanchansf ryanchansf merged commit 232c728 into develop May 14, 2024
4 checks passed
@ryanchansf ryanchansf deleted the 129-fix-table-column-sorting branch May 14, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix table column sorting
2 participants