Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move acknowledged team members into Airtable + create API route for team member fetching #1391

Merged
merged 6 commits into from
Oct 21, 2024

Conversation

DaInfLoop
Copy link
Member

This PR moves people from the acknowledgements section of the page to Airtable - aswell as introducing /api/team for fetching team members, removing the need for https://github.com/hackclub/team.

People on the team page also now are given websites based off their Slack profile, similar to how some people in the Acknowledgements section can have one. This can be set on Airtable too - however the Slack profile takes precedence.

This PR only affects users in Hacker Resources Team, HCB Team and Acknowledgements section. The Board & Advisors section is completely untouched.

Post-merge requirements:
Current copy table on Airtable to be renamed to Current.

Copy link

vercel bot commented Sep 28, 2024

@DaInfLoop is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Sep 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
site ✅ Ready (Inspect) Visit Preview 💬 7 unresolved Oct 21, 2024 6:36pm

@lachlanjc
Copy link
Member

lachlanjc commented Sep 28, 2024

📝 Changed routes:

/team
Screenshot of /team
(view full size)

And 1 other route:

Commit f3583ee (https://site-yyaipxqs0.hackclub.dev).

pages/api/team.js Show resolved Hide resolved
pages/api/team.js Show resolved Hide resolved
pages/api/team.js Show resolved Hide resolved
pages/api/team.js Outdated Show resolved Hide resolved
pages/api/team.js Show resolved Hide resolved
@@ -547,11 +279,9 @@ When not busy juggling different tasks he takes up, he enjoys tinkering & buildi

export const getServerSideProps = async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DaInfLoop all you need to do is use static probs instead of server side props and no need to cache i suppose

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just make sure to validate it in the background every so and so minute

Copy link
Member

@sampoder sampoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cskartikey for the previous review & @DaInfLoop for the great PR! Just looks like avatars need to be fixed, once they're rendering as expected in staging, @cskartikey please ping me again on Slack and I can merge.

@cskartikey
Copy link
Member

@sampoder I'm not 100% sure why pfps aren't loading. They seem to load perfectly on local deployment. Maybe a vercel issue?

pages/api/team.js Outdated Show resolved Hide resolved
@grymmy grymmy added this pull request to the merge queue Oct 21, 2024
Merged via the queue into hackclub:main with commit 1fd56b2 Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants