-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move acknowledged team members into Airtable + create API route for team member fetching #1391
Conversation
@DaInfLoop is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 Changed routes:
And 1 other route: Commit f3583ee (https://site-yyaipxqs0.hackclub.dev). |
@@ -547,11 +279,9 @@ When not busy juggling different tasks he takes up, he enjoys tinkering & buildi | |||
|
|||
export const getServerSideProps = async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DaInfLoop all you need to do is use static probs instead of server side props and no need to cache i suppose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just make sure to validate it in the background every so and so minute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cskartikey for the previous review & @DaInfLoop for the great PR! Just looks like avatars need to be fixed, once they're rendering as expected in staging, @cskartikey please ping me again on Slack and I can merge.
@sampoder I'm not 100% sure why pfps aren't loading. They seem to load perfectly on local deployment. Maybe a vercel issue? |
+ remove automatically fetching websites from Slack
This PR moves people from the acknowledgements section of the page to Airtable - aswell as introducing
/api/team
for fetching team members, removing the need for https://github.com/hackclub/team.People on the team page also now are given websites based off their Slack profile, similar to how some people in the Acknowledgements section can have one. This can be set on Airtable too - however the Slack profile takes precedence.
This PR only affects users in Hacker Resources Team, HCB Team and Acknowledgements section. The Board & Advisors section is completely untouched.
Post-merge requirements:
Current copy
table on Airtable to be renamed toCurrent
.