-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace html elements with MUI in editableField.jsx #1849
base: development
Are you sure you want to change the base?
Replace html elements with MUI in editableField.jsx #1849
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Low risk because it is an unused component, approved
@trillium Can we merge this PR? Looks like we have 2 approving reviews from Holly & Lucie. Looks like some of the fields may be slightly misaligned (e.g., "edit" is contained on a separate line from "Some Field")... |
Fixes #1700
Note:
This seems to be an unused component, but I went ahead and made the changes anyways.
What changes did you make and why did you make them ?
div
tag with MUIBox
componenetbutton
tag with MUIButton
componenttextarea
tag with MUITextareaAutosize
componentinput
tag with MUITextField
componentScreenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied