Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HTML components to MUI components for ManageProjects page #1850

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Update HTML components to MUI components for ManageProjects page #1850

wants to merge 2 commits into from

Conversation

jng34
Copy link
Member

@jng34 jng34 commented Jan 30, 2025

Fixes #1719

What changes did you make and why did you make them ?

  • Replaced HTML span tag with MUI Typography component
  • Replaced HTML img tag with MUI Box component
  • Added custom style properties to match original CSS
  • WHY: To modernize the frontend components

Screenshots of Proposed Changes Of The Website

Visuals before changes are applied 1719 before screen
Visuals after changes are applied 1719 after screen

@github-actions GitHub Actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jng34-updateMUIforManageProjects development
git pull https://github.com/jng34/VRMS.git updateMUIforManageProjects

dannyprikaz
dannyprikaz approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@dannyprikaz dannyprikaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor notes about changing styling and which MUI components were used, but this solution works. I approve

@dannyprikaz dannyprikaz added the ready for 2nd review When a PR is ready for another reviewer label Feb 6, 2025
bconti123
bconti123 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@bconti123 bconti123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the changes on VRMS website. Everything works. MUI code looks much cleaner!

@bconti123 bconti123 added the ready for dev lead Add to issue when dev lead needs to take some action label Feb 18, 2025
bconti123
bconti123 reviewed Feb 18, 2025
View reviewed changes
Copy link
Member

@bconti123 bconti123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trillium, I added ready for dev lead. label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bconti123 bconti123 bconti123 approved these changes

@dannyprikaz dannyprikaz dannyprikaz approved these changes

Assignees
No one assigned
Labels
complexity: small ready for dev lead Add to issue when dev lead needs to take some action ready for 2nd review When a PR is ready for another reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update HTML components to MUI: ./src/pages/ManageProjects.js
4 participants
@jng34 @dannyprikaz @bconti123 @JackHaeg