Unit Testing for Auth Router #1927
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jng34 - It looks like there are some conflicts in this PR. Can you please resolve these conflicts when you have a moment? |
|
@JackHaeg Oops! I might have made a mistake. Let me confirm again once resolved. Sorry! |
|
@JackHaeg The conflict should be resolved. |
|
@dannyprikaz FYI - this PR is now ready for review per @jng34 👍 |
|
@jng34 This is the PR that was discussed on tonight's call. Please take a look at it when you have a moment to double check if this was closed by accident :) |
|
@JackHaeg I was removing old branches on my local machine, and might have deleted the branch associated with this PR. I don't think it should have closed the PR though...weird. Anyway, I have reopened it. |
|
PR is ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1885
What changes did you make and why did you make them ?
auth.routerScreenshots of Passed Tests