add test for events routers #1956
Open
+247
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyprikaz
requested changes
Jun 10, 2025
| it('should call EventController.create and return the created event', async (done) => { | ||
| EventController.create.mockImplementationOnce((req, res) => res.status(201).send(mockEvent)); | ||
|
|
||
| const newEventData = { |
There was a problem hiding this comment.
Don't really need this object. We could just reuse. mockEvent
| it('should return 500 if an error occurs when fetching next event by project', async (done) => { | ||
| const mockError = new Error('Simulated database error for next event by project'); | ||
|
|
||
| Event.find.mockImplementationOnce(() => ({ |
There was a problem hiding this comment.
Please write some comments for this and other sections
|
|
||
| const response = await request.get(`/api/events/nexteventbyproject/${mockProjectId}`); | ||
|
|
||
| expect(Event.find).toHaveBeenCalledWith({ project: mockProjectId }); |
There was a problem hiding this comment.
Don't need these conditions that are tested in the last test case.
|
Update - @angela-lee1 will be updating this PR over the course of this week |
|
Terribly sorry about the delay. I'll get it completed by tonight or tomorrow night. No blockers. |
Hey @dannyprikaz @trillium , terribly sorry about the delay. I am quite free this weekend. Should any updates be needed, please feel free to send a message in Slack.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1888
What changes did you make and why did you make them ?